Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NodeFactory.py #43

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update NodeFactory.py #43

merged 1 commit into from
Jul 2, 2024

Conversation

raucha
Copy link
Contributor

@raucha raucha commented Apr 18, 2022

#42

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 18, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.36%.

Quality metrics Before After Change
Complexity 9.68 🙂 11.49 🙂 1.81 👎
Method Length 66.80 🙂 71.20 🙂 4.40 👎
Working memory 9.02 🙂 9.20 🙂 0.18 👎
Quality 61.15% 🙂 57.79% 🙂 -3.36% 👎
Other metrics Before After Change
Lines 69 75 6
Changed files Quality Before Quality After Quality Change
graphviz2drawio/mx/NodeFactory.py 61.15% 🙂 57.79% 🙂 -3.36% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
graphviz2drawio/mx/NodeFactory.py NodeFactory.from_svg 17 🙂 163 😞 11 😞 44.04% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@hbmartin hbmartin merged commit 4fb802b into hbmartin:master Jul 2, 2024
@hbmartin
Copy link
Owner

hbmartin commented Jul 2, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants