Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multiple CA in ca.crt file #190

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

leszko
Copy link

@leszko leszko commented Jan 29, 2020

Before only the first CA Certificate was read from the ca.crt file, which made the discovery failing in case of multiple entries in ca.crt.

This PR is a follow-up of the IBM Cloud Pak certification process.

Copy link
Member

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about renaming RestClient.withCaCertificate method to withCaCertificates?

There could be also a test related issue on IBM JDKs (if we support this runtime). IBM JDK has a sensitive X.509 parser, so the empty lines within ca.crt could cause some troubles.

Otherwise LGTM.

@leszko
Copy link
Author

leszko commented Jan 29, 2020

What do you think about renaming RestClient.withCaCertificate method to withCaCertificates?

Good idea, renamed!

There could be also a test related issue on IBM JDKs (if we support this runtime). IBM JDK has a sensitive X.509 parser, so the empty lines within ca.crt could cause some troubles.

I believe we don't have to test it using IBM JDK, because we don't publish any Docker image based on IBM JDK. Also, I believe that if ca.crt (generated by Kubernetes) would not be compatible with IBM JDK parser, then it won't be only the problem of Hazelcast, but a lot of other tools.

Otherwise LGTM.

Thanks for the review @kwart !!!

@leszko leszko requested a review from kwart January 29, 2020 14:15
@leszko leszko merged commit e731619 into hazelcast:master Jan 29, 2020
@leszko leszko deleted the fix-multi-ca branch January 29, 2020 14:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants