Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change number of retries to 3 #48

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Change number of retries to 3 #48

merged 1 commit into from
Aug 11, 2020

Conversation

leszko
Copy link

@leszko leszko commented Aug 6, 2020 •
edited
Loading

Changed to the same value as other plugins. Also, the current value (10) was too high.

@leszko leszko requested a review from mtyazici August 6, 2020 13:03
@leszko leszko requested a review from a team as a code owner August 6, 2020 13:03
@leszko leszko requested review from mesutcelik and alparslanavci and removed request for a team and alparslanavci August 6, 2020 13:03
mesutcelik
mesutcelik approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@mesutcelik mesutcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can we add a description why we do this? Most probably to be aligned with others but not sure?

@leszko leszko merged commit 059edac into master Aug 11, 2020
@leszko leszko deleted the leszko-patch-2 branch August 11, 2020 10:16
@leszko leszko added this to the 2.1 milestone Aug 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesutcelik mesutcelik mesutcelik approved these changes

@mtyazici mtyazici mtyazici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@leszko @mesutcelik @mtyazici