Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage-report.yaml by adding Java 17 JDK #1236

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Aug 22, 2024

coverage-report.yaml is failing because the wrong JDK is being used.

This PR replicates the JDK configuration of the coverage part of the PR builder.

(`coverage-report.yaml` is failing](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/10508991450) because the wrong JDK is being used.

This PR replicates the JDK configuration of the coverage part of the PR builder
@JackPGreen
Copy link
Contributor Author

@ihsandemir are you able to review, please?

This is better fixed as part of #1237 but I'd already done this.

Copy link
Collaborator

@ihsandemir ihsandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try running it and it passed?

@JackPGreen
Copy link
Contributor Author

did you try running it and it passed?

I am not able to run it because it requires secrets not accessible from my fork.

Copy link
Collaborator

@ihsandemir ihsandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will test after merge.

@JackPGreen JackPGreen marked this pull request as draft September 6, 2024 09:12
@JackPGreen JackPGreen closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants