Skip to content

Commit

Permalink
pythongh-118729: Temporarily skip `test_multiprocessing_pool_circular…
Browse files Browse the repository at this point in the history
…_import` (python#118732)

The `pool_in_threads.py` test file may crash in free-threaded builds,
which can lead to the Tsan test hanging. Skip it for now until we fix
the underlying issue.
  • Loading branch information
colesbury authored May 7, 2024
1 parent f58833e commit 2c19987
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Lib/test/test_importlib/test_threaded_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from test.support import verbose
from test.support.import_helper import forget, mock_register_at_fork
from test.support.os_helper import (TESTFN, unlink, rmtree)
from test.support import script_helper, threading_helper
from test.support import script_helper, threading_helper, requires_gil_enabled

threading_helper.requires_working_threading(module=True)

Expand Down Expand Up @@ -248,6 +248,9 @@ def test_concurrent_futures_circular_import(self):
'partial', 'cfimport.py')
script_helper.assert_python_ok(fn)

# gh-118727 and gh-118729: pool_in_threads.py may crash in free-threaded
# builds, which can hang the Tsan test so temporarily skip it for now.
@requires_gil_enabled("gh-118727: test may crash in free-threaded builds")
def test_multiprocessing_pool_circular_import(self):
# Regression test for bpo-41567
fn = os.path.join(os.path.dirname(__file__),
Expand Down

0 comments on commit 2c19987

Please sign in to comment.