Added support for Properties files #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidePastore
requested changes
Oct 12, 2020
There was a problem hiding this comment.
Hi @markdegrootnl and thanks for your PR! I added a comment in the review and it would be amazing if you can also add that this package supports .properties file on top of README.md, where we have the "Config is a file configuration loader that supports" text.
DavidePastore
approved these changes
Oct 13, 2020
|
@markdegrootnl, thanks for your fast changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Java properties files.
Properties files are close to ini files, but as @DavidePastore pointed out, not completely the same. That's why I've written a dedicated parser and writer.