Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package depends on Symfony/Yaml but it is only suggest? #97

Closed
bfday opened this issue Feb 24, 2018 · 3 comments
Closed

Package depends on Symfony/Yaml but it is only suggest? #97

bfday opened this issue Feb 24, 2018 · 3 comments

Comments

@bfday
Copy link

bfday commented Feb 24, 2018

This file shows that this package requires Symfony\Component\Yaml\Yaml but it's only a suggest in composer.json
"suggest": { "symfony/yaml": "~2.5" },
is it ok? Seems that it's a requirement not only a suggestion.

@DavidePastore
Copy link
Collaborator

Hi @bfday. symfony/yaml is used only when you need to parse YAML files. I think not everybody has this need, but in the case one has, we should explicitly indicate it. Maybe @hassankhan could give a more detailed explanation.

@hassankhan
Copy link
Owner

Pretty much what @DavidePastore said - if a user needs to parse YAML files, they'd need to also install the symfony/yaml package, otherwise users would get an unnecessary package installed.

@DavidePastore DavidePastore added this to the 1.0.0 milestone Mar 3, 2018
@DavidePastore
Copy link
Collaborator

Added a more explicit reference about the symfony/yaml requirement in #102.

peter279k pushed a commit to open-source-contributions/config that referenced this issue May 8, 2021
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 0.12.82 to 0.12.83.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Commits](phpstan/phpstan@0.12.82...0.12.83)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants