Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spurious aborts when retrying transactions #34

Closed
wants to merge 3 commits into from
Closed

Fix spurious aborts when retrying transactions #34

wants to merge 3 commits into from

Commits on Oct 11, 2019

  1. Fix spurious aborts when retrying transactions 

    Transactions that enter an error state must be aborted manually by
issuing a "ROLLBACK". However, if the transaction error happened during
a "COMMIT" then the rollback happens automatically. Issuing a "ROLLBACK"
at this point causes PostgreSQL to issue a "WARNING: There is no
transaction in progress". This warning can have much worse causes (e.g.
you "COMMIT" but never began a transaction). This change makes the
transaction retrying logic never cause PostgreSQL to issue this warning
making it a more useful warning for detecting real bugs.
    @3noch
    3noch committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    184c74f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Only catch SqlError in retryLoop

    @3noch
    3noch committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    e02684f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Merge remote-tracking branch 'origin/master' into eac@fix-spurious-ab… 

    …orts
    @3noch
    3noch committed May 9, 2020
    Configuration menu
    Copy the full SHA
    829e1e4 View commit details
    Browse the repository at this point in the history