Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromJSONField: Include JSONPath on JSON parse errors #2

Merged
merged 1 commit into from
Nov 28, 2018
Merged

fromJSONField: Include JSONPath on JSON parse errors #2

merged 1 commit into from
Nov 28, 2018

Conversation

sol
Copy link
Contributor

@sol sol commented Nov 23, 2018

No description provided.

@phadej
Copy link
Collaborator

phadej commented Nov 23, 2018

this new fromJSON doesn't seem to be used anywhere?

@sol
Copy link
Contributor Author

sol commented Nov 23, 2018 •
edited
Loading

this new fromJSON doesn't seem to be used anywhere?

My bad, fixed.

@sol
Copy link
Contributor Author

sol commented Nov 23, 2018

@phadej aeson's fromJSON does not include the JSONPath to the location where parsing failed in error messages. I addressed this by using ifromJSON.

@sol
Copy link
Contributor Author

sol commented Nov 28, 2018

@phadej is there anything that I can do to move this forward?

@phadej
Copy link
Collaborator

phadej commented Nov 28, 2018

@sol this looks good.

@phadej phadej merged commit 466c469 into haskellari:master Nov 28, 2018
@phadej
Copy link
Collaborator

phadej commented Nov 28, 2018

Merged, thanks for the ping

@sol sol deleted the better-json-errors branch November 28, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sol @phadej