Attempt to run doctests with GHC that were disabled #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And it blew up on macos. (Linker errors when running doctests) |
624c0ab fixed most of the issues. And indeed we can run doctests on GHC>=8.6. However running doctests on macos caused linker errors for GHC 8.10 and 9.0 > ld: warning: -undefined dynamic_lookup may not work with chained fixups
Shimuuar
force-pushed
the
doctests-versions
branch
from
c7dccca
to
b28abec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 624c0ab did fix doctest with old GHCs we can remove conditionals.