Optimize replicateM and update CI #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also avoids useless vector initialization
Windows builds were pain so they're left as it is
|
And look at it! Doctests blew up again. I'll look into it tomorrow |
[-Wtype-equality-requires-operators]
I don't know what am I doing really. But doctests now work
|
I managed to fix doctests on GHC 9.4 & 9.6. It's a big hack but it does work. It seems there's state leakage between running tests on different modules and it caused tests to fail |
lehins
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turn out to be a bit of kitchen sink
munstreaminstead of hand-rolled loop inreplicateMfor mutable vectors. It also avoid double initialization of buffer withnew(noticed by @dmalkr)TestEqand default implementation forequalsmethod ofTestDatatype class.