-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UnboxViaPrim docs #450
Conversation
Thanks for noticing this! vector/vector/src/Data/Vector/Unboxed.hs Lines 61 to 63 in 5948c60
I don't remember why |
It's always been like that 4c7bf23. It's difficult to say what are reasons though. I think it would be better to add |
Yes, I agree that exporting |
Updated, the only thing being not sure whether to export only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot about this PR. LGTM. @sergv thank you for your contribution.
The doctest examples for
UnboxViaPrim
(https://hackage.haskell.org/package/vector-0.13.0.0/docs/Data-Vector-Unboxed.html#t:UnboxViaPrim) are not self-contained.When using one of them as-is
I get following error with GHC 9.4
After fixing qualified imports I try again with
but now the error is actually interesting and this is what made me create this PR:
finally if I fix this too I’ll get output
I propose to amend doctest for
UnboxViaPrim
to make it working. I have also took liberty to sort imports and qualify imported module’s names in the same way doctest forIsoUnbox
does for consistency (in a separate commit for ease of discarding it if it proves too controversial).