Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS auth backend iam_request_headers to be TypeHeader #5320

Merged
merged 16 commits into from
Sep 12, 2018

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Sep 11, 2018

Use TypeHeader introduced in #4993 for the AWS auth backend's iam_request_headers input. The current behavior only allows base64 encoded strings. This PR updates that to support base64 strings as well as JSON headers as mentioned in #4993

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it through, checked it out, ran the tests, this looks great. Thanks Clint!

chrishoffman
chrishoffman previously approved these changes Sep 11, 2018
builtin/credential/aws/path_login.go Outdated Show resolved Hide resolved
@catsby catsby merged commit d070b36 into master Sep 12, 2018
@catsby catsby deleted the aws-auth-headers branch September 12, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants