Config to skip TLS cert verification for etcd #5297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new configuration option to the etcd backend section. tls_insecure_skip_verify allows the user to instruct vault to skip the verification of the certificates presented by etcd. Setting tls_insecure_skip_verify to 'true' is a work around to issue hashicorp#4961. If a user sets tls_insecure_skip_verify to 'true' then vault is vunerable to man-in-the-middle attacks when communicating with etcd.
|
|
| return nil, errwrap.Wrapf(fmt.Sprintf("value of 'tls_insecure_skip_verify' (%v) could not be understood: {{err}}", sskip), err) | ||
| } | ||
| tls.InsecureSkipVerify = skip | ||
| } else { |
There was a problem hiding this comment.
This is going to default to false and you don't need to set it explicitly.
There was a problem hiding this comment.
This is going to default to false and you don't need to set it explicitly.
Is it still true?
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new configuration option to the etcd backend
section. tls_insecure_skip_verify allows the user to instruct
vault to skip the verification of the certificates presented by
etcd. Setting tls_insecure_skip_verify to 'true' is a work around
to issue #4961. If a user sets tls_insecure_skip_verify to 'true'
then vault is vunerable to man-in-the-middle attacks when
communicating with etcd.
I am proposing the change as its the work-around I'm currently
using for the bug and I thought it might be useful to others. However,
given the security implications of enabling the option I understand if
you choose not to land it.