Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuning visibility in CLI #4827

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Conversation

jefferai
Copy link
Member

The API elides the value if it's empty, but empty has meaning. This adds
"hidden" as an option which is fundamentally identical to the default.

The API elides the value if it's empty, but empty has meaning. This adds
"hidden" as an option which is fundamentally identical to the default.
@jefferai jefferai requested a review from calvn June 25, 2018 14:40
@jefferai jefferai added this to the 0.10.4 milestone Jun 25, 2018
@calvn
Copy link
Contributor

calvn commented Jun 25, 2018

Currently an empty value's meaning is that it's hidden. Do we intend to have that be something different? If so, what's the difference between hidden vs empty?

@jefferai
Copy link
Member Author

jefferai commented Jun 27, 2018

@calvn Using an actual real string keeps the API from eliding the value due to omitempty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants