don't check capabilities before rendering the credentials route #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
force-pushed
the
ui-no-creds-capabilities-check
branch
from
87f0e48
to
349a5c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the UI we were trying to smooth over not having the right capabilities when generating credentials via dynamic secrets engines - if you didn't have update permissions (most api actions are POST), then we'd just redirect you back to the list. But! it's not always so simple as the AWS engine does GET for IAM, and POST for STS - so instead of checking for every combination, we'll let the ACL system do its job and just show the error in the UI.
There may be some back-button-pressing for some users, but the UI and CLI should be consistent in the use of required ACLs ( #4335 (comment) for the report).