s3.go: Added options to use paths with S3 and the ability to disable SSL #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Dec 26, 2017
physical/s3/s3.go
Outdated
| @@ -72,6 +72,22 @@ func NewS3Backend(conf map[string]string, logger log.Logger) (physical.Backend, | |||
| } | |||
| } | |||
| } | |||
| s3ForceStylePathStr, ok := conf["s3_force_style_path"] | |||
There was a problem hiding this comment.
Please change this and the following value to s3ForcePathStyle, which matches the actual parameter (PathStyle instead of StylePath).
jefferai
reviewed
Dec 26, 2017
physical/s3/s3.go
Outdated
| if !ok { | ||
| s3ForceStylePathStr = "false" | ||
| } | ||
| s3ForceStylePathBool, err := strconv.ParseBool(s3ForceStylePathStr) |
There was a problem hiding this comment.
Please use parseutil.ParseBool instead.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3728.