Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Query Updates #27547

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Handle Query Updates #27547

wants to merge 3 commits into from

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Jun 20, 2024

Description

Change HandleQuery so as to return the updated current month estimation values.
Tests are available in the matching ENT PR.

Matching ENT Pr: https://github.com/hashicorp/vault-enterprise/pull/6102
closes https://github.com/hashicorp/vault-enterprise/pull/6102

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jun 20, 2024

Build Results:
All builds succeeded! ✅

@miagilepner
Copy link
Contributor

I was confused about why no tests were failing, before realizing that there's a bug in the implementation which is fixed here: #27549.

@divyaac divyaac force-pushed the VAULT-28026_Handle_Query_Updates branch from 6e2e51a to 3d1fb66 Compare June 21, 2024 05:52
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a test to vault/external_tests/activity_testonly/activity_testonly_test.go to verify the response in the total field as well as the mount breakdowns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants