-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Query Updates #27547
base: main
Are you sure you want to change the base?
Handle Query Updates #27547
Conversation
CI Results: |
Build Results: |
I was confused about why no tests were failing, before realizing that there's a bug in the implementation which is fixed here: #27549. |
6e2e51a
to
3d1fb66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a test to vault/external_tests/activity_testonly/activity_testonly_test.go
to verify the response in the total field as well as the mount breakdowns?
Description
Change HandleQuery so as to return the updated current month estimation values.
Tests are available in the matching ENT PR.
Matching ENT Pr: https://github.com/hashicorp/vault-enterprise/pull/6102
closes https://github.com/hashicorp/vault-enterprise/pull/6102
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+ent
labelsinstead of the old style
backport/x.x.x
labels.the normal
backport/x.x.x
label (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.