Backport of Fix PKCS7 parser failing to parse degenerated certificate messages into release/1.17.x #27447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-28030-pkcs7-issues/promptly-curious-dog
branch
from
9938eae
to
680f4d8
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
stevendpclark
approved these changes
Jun 11, 2024
|
CI Results: |
|
Build Results: |
stevendpclark
deleted the
backport/stevendpclark/vault-28030-pkcs7-issues/promptly-curious-dog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27435 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
A properly formatted PKCS7 message with unsigned multiple certificates is hitting a conditional check that the offset value is greater than the buffer. While that is true, in this use case we don't attempt to read from the buffer again so the check for buffer boundaries causes the parser to fail to read a message.
Tweak the offset checks to occur just before we are about to read from
bufusing theoffsetvariable and not after we increment theoffsetvariable. Augment theTestDegenerateCertificateto parse its own generated message along with OpenSSL that exposes the issue before the fixes tober.goOverview of commits