Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the configured address's path in the client #2588

Merged
merged 4 commits into from
Apr 13, 2017

Conversation

leeavital
Copy link
Contributor

This is necessary if you have vault sitting behind a reverse-proxy like
nginx under a context path and you need to talk to vault at:
https://hostname.com/vault

Lee Avital added 2 commits April 12, 2017 13:25
This is necessary if you have vault sitting behind a reverse-proxy like
nginx under a context path and you need to talk to vault at:
https://hostname.com/vault
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Just one small comment.

api/client.go Outdated
@@ -336,7 +336,7 @@ func (c *Client) NewRequest(method, path string) *Request {
User: c.addr.User,
Scheme: c.addr.Scheme,
Host: c.addr.Host,
Path: path,
Path: strings.TrimSuffix(c.addr.Path, "/") + path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use path.Join() instead of trimming the "/"?

@leeavital
Copy link
Contributor Author

@briankassouf should be good to go!

@jefferai jefferai added this to the 0.7.1 milestone Apr 13, 2017
@jefferai jefferai merged commit 24299b8 into hashicorp:master Apr 13, 2017
chrishoffman pushed a commit that referenced this pull request Apr 17, 2017
* oss/master: (43 commits)
  Bump deps
  Update SSH docs to indicate deprecation of dynamic key type
  Bump Go version in Travis
  changelog++
  Bump go version to 1.8.1
  Consider new bounds as a criteria to allow role creation (#2600)
  Update 404.html.md (#2594)
  Add some extra documentation around ssh-keygen -L to see signed cert info.
  changelog++
  Respect the configured address's path in the client (#2588)
  changelog++
  Verify that a CSR specifies IP SANs before checking whether it's allowed (#2574)
  minor docs update
  changelog++
  Update AES-GCM verification text
  changelog++
  implement a no_store option for pki roles (#2565)
  Remove superfluous/misleading comments around some listener options
  Update SSH CA documentation
  Add press-kit
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants