Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable hierarchical path for library sets #105

Merged
merged 17 commits into from
May 16, 2024
Merged

enable hierarchical path for library sets #105

merged 17 commits into from
May 16, 2024

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented May 10, 2024 •
edited
Loading

Phase 3 of #102 and #104

This PR adds hierarchical path handling to the following APIs:

@fairclothjm fairclothjm marked this pull request as ready for review May 14, 2024 15:54
@fairclothjm fairclothjm requested a review from a team May 14, 2024 15:55
@fairclothjm fairclothjm changed the title Lib set/vault 26642/hierarchical paths enable hierarchical path for library sets May 14, 2024
kpcraig
kpcraig approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@kpcraig kpcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, although i confess parsing through the regexes gave me a bit of a headache. (The tests helped convince me)

@benashz benashz self-requested a review May 16, 2024 02:01
benashz
benashz approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@fairclothjm fairclothjm merged commit 1519138 into main May 16, 2024
4 checks passed
@fairclothjm fairclothjm deleted the lib-set/VAULT-26642/hierarchical-paths branch May 16, 2024 21:07
@fairclothjm fairclothjm mentioned this pull request May 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpcraig kpcraig kpcraig approved these changes

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairclothjm @kpcraig @benashz @austingebauer