fix: disable handling update on pods #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
approved these changes
May 10, 2024
There was a problem hiding this comment.
LGTM, thanks for raising this. IIUC this should mostly be fixed with #501 which got released in v1.3.0, but it's nice to do this bit of cleanup as well.
I'll leave this over the weekend before merging in case you want to address the suggestion, but I'm also fine with merging as-is and addressing the comment in a follow-up.
tvoran
reviewed
Jul 12, 2024
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
tvoran
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #547
Relates to hashicorp/vault-helm#783
Also adds the
Namespacedscope to the rule.