-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable handling update on pods #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for raising this. IIUC this should mostly be fixed with #501 which got released in v1.3.0, but it's nice to do this bit of cleanup as well.
I'll leave this over the weekend before merging in case you want to address the suggestion, but I'm also fine with merging as-is and addressing the comment in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more addition and I think we're good!
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Fixes #547
Relates to hashicorp/vault-helm#783
Also adds the
Namespaced
scope to the rule.