-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hostAliases to chart #897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, also would you mind adding some tests for this new parameter in test/unit/server-statefulset.bats?
@@ -442,6 +442,12 @@ server: | |||
# hosts: | |||
# - chart-example.local | |||
|
|||
# hostAliases is a list of aliases to be added to /etc/hosts. Specified as a YAML list. | |||
hostAliases: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could default this to an empty list, and that would make the json schema definition a little simpler (no null
needed).
hostAliases: null | |
hostAliases: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tvoran thanks for taking a look! Sorry for the delay, things have been a bit busy for me but I'll add some tests and update the PR with the schema suggestion soon.
@andrewroffey are you planning to add tests? |
@tombokombo I have dragged my feet on this one, mostly because we aren't using the Helm chart anymore (for now). I'll add some tests on my repo next week but I won't re-sign a new CLA because of the license thing. |
Add hostAliases to the Vault Helm Chart so that custom entries can be added to /etc/hosts via values.yaml.
Comes in handy for adding host entries to 127.0.0.1 (e.g. to use a 'normal' cert rather than an IP SAN cert) and possibly other uses.