Add hostAliases to chart #897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
|
|
tvoran
reviewed
Jun 17, 2023
| @@ -442,6 +442,12 @@ server: | |||
| # hosts: | |||
| # - chart-example.local | |||
|
|
|||
| # hostAliases is a list of aliases to be added to /etc/hosts. Specified as a YAML list. | |||
| hostAliases: null | |||
There was a problem hiding this comment.
I think we could default this to an empty list, and that would make the json schema definition a little simpler (no null needed).
Suggested change
| hostAliases: null | |
| hostAliases: [] |
There was a problem hiding this comment.
@tvoran thanks for taking a look! Sorry for the delay, things have been a bit busy for me but I'll add some tests and update the PR with the schema suggestion soon.
|
@andrewroffey are you planning to add tests? |
|
@tombokombo I have dragged my feet on this one, mostly because we aren't using the Helm chart anymore (for now). I'll add some tests on my repo next week but I won't re-sign a new CLA because of the license thing. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hostAliases to the Vault Helm Chart so that custom entries can be added to /etc/hosts via values.yaml.
Comes in handy for adding host entries to 127.0.0.1 (e.g. to use a 'normal' cert rather than an IP SAN cert) and possibly other uses.