-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Cleanup the Lambda ENI deletion process a bit #8486
provider/aws: Cleanup the Lambda ENI deletion process a bit #8486
Conversation
@@ -359,7 +359,10 @@ func resourceAwsSecurityGroupDelete(d *schema.ResourceData, meta interface{}) er | |||
|
|||
log.Printf("[DEBUG] Security Group destroy: %v", d.Id()) | |||
|
|||
deleteLingeringLambdaENIs(conn, d) | |||
err := deleteLingeringLambdaENIs(conn, d) | |||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since only the err is used here can we use the if err := ...; err != nil {
style here?
One nit, then LGTM |
d30d14b
to
d6d96ba
Compare
Nit fixed, merging. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Just a little bit of cleanup after merging #8033 to explain why do we have the function there + to catch errors.
cc @gposton