vmss - support specifying ultra_ssd_disk_iops_read_write and ultra_ssd_disk_mbps_read_write for PremiumV2_LRS
#21530
Conversation
…d_write` for `PremiumV2_LRS`
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| if !features.FourPointOhBeta() { | ||
| schema.Elem.(*pluginsdk.Resource).Schema["ultra_ssd_disk_iops_read_write"] = &pluginsdk.Schema{ |
There was a problem hiding this comment.
When we switch to plugin framework this may not work as expected anymore - could we add a TODO to make the rename in 4.0 instead of doing the deprecation? Whilst we would normally recommend doing a deprecation here, this could cause confusion because all four fields are computed.
There was a problem hiding this comment.
Hi @myc2h6o thanks for this! I left one comment inline about the deprecation portion of this change - it would be good if we did this in 4.0 rather as a deprecation here. As such, could we rework this to include only the validation change? Thanks!
myc2h6o
changed the title
vmss - support specifying disk_iops_read_write and disk_mbps_read_write for PremiumV2_LRSvmss - support specifying ultra_ssd_disk_iops_read_write and ultra_ssd_disk_mbps_read_write for PremiumV2_LRS
|
Hi @catriona-m thanks for reviewing the change! I see your point and use comments instead, please take a look |
|
This functionality has been released in v3.56.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Close #21108
ultra_ssd_disk_[io|mb]ps_read_writetodisk_[io|mb]ps_read_writein 4.0 since these are now supported for not only ultra ssd but alsoPremiumV2_LRS1, which is taken from https://learn.microsoft.com/azure/virtual-machines/disks-types#ultra-disk-throughput andmanaged_disk