Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PremiumV2_LRS data disks attached to linux scale set VMs don't allow configuration of IOPs and MBps #21108

Closed
1 task done
awkimball opened this issue Mar 24, 2023 · 2 comments · Fixed by #21530
Closed
1 task done
Labels
enhancement service/vmss Virtual Machine Scale Sets v/3.x
Milestone

Comments

@awkimball
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.3.9

AzureRM Provider Version

3.48.0

Affected Resource(s)/Data Source(s)

azurerm_linux_virtual_machine_scale_set

Terraform Configuration Files

resource "azurerm_linux_virtual_machine_scale_set" "gitlab_runners_linux" {
    name = "${local.name_prefix}-scaleset"
    resource_group_name = azurerm_resource_group.gitlab_runners_linux.name
    location = azurerm_resource_group.gitlab_runners_linux.location
    sku = var.linux_vm_type
    instances = var.initial_linux_instances
    admin_username = "admin"
    zones = ["1"]

    source_image_id = var.linux_image_id

    os_disk {
        storage_account_type = "Premium_LRS"
        caching = "ReadWrite"
        disk_size_gb = "${var.os_disk_size_gb}"
    }

    additional_capabilities {
        ultra_ssd_enabled = false
    }

    data_disk {
        caching = "None"
        disk_size_gb = 128
        storage_account_type = "PremiumV2_LRS"
        lun = 1

        disk_iops_read_write = 7500
        disk_mbps_read_write = 500
    }
    

    admin_ssh_key {
        username = "admin"
        public_key = tls_private_key.gitlab_runners_linux_key.public_key_openssh
    }

    network_interface {
        name = "${local.name_prefix}-scaleset-nic"
        primary = true

        ip_configuration {
            name = "${local.name_prefix}-scaleset-ipconfig-internal"
            primary = true
            subnet_id = azurerm_subnet.gitlab_runners_linux_internal.id
        }
    }

    custom_data = data.cloudinit_config.gitlab_runners_linux_config.rendered

    lifecycle {
        ignore_changes = [instances]
        replace_triggered_by = [null_resource.linux_image_id, null_resource.gitlab_runners_linux_config]
    }
}

Debug Output/Panic Output

Error: Unsupported argument
│ 
│   on modules/azure-gitlab-runners-linux/main.tf line 136, in resource "azurerm_linux_virtual_machine_scale_set" "gitlab_runners_linux":
│  136:         disk_iops_read_write = 7500
│ 
│ An argument named "disk_iops_read_write" is not expected here.
╵
╷
 Error: Unsupported argument
│ 
│   on modules/azure-gitlab-runners-linux/main.tf line 137, in resource "azurerm_linux_virtual_machine_scale_set" "gitlab_runners_linux":
│  137:         disk_mbps_read_write = 500
│ 
│ An argument named "disk_mbps_read_write" is not expected here.
╵

Expected Behaviour

According to #18991 , this behavior was developed and merged in when creating a managed disk of type PremiumV2_LRS. disk_iops_read_write and disk_mbps_read_write are configurable. It is expected that when creating this same disk type attached to a VM in a linux scale set, these same configuration options would be present.

Actual Behaviour

disk_iops_read_write and disk_mbps_read_write are not valid options for a data_disk block with type PremiumV2_LRS on to a VM that is part of a linux scale set.

Steps to Reproduce

  1. terraform plan

Important Factoids

No response

References

Issue regarding same problem with managed disks that has been fixed: #18977
Relevant pull request: #18991

Thanks!

@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/vmss Virtual Machine Scale Sets v/3.x
Projects
None yet
3 participants