-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F aws transfer server structured logging destinations #32654
F aws transfer server structured logging destinations #32654
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Sorry I see I have some lint issues. I will get those resolved and push those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/^basic$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run=TestAccTransfer_serial/Server/^basic$ -timeout 180m
=== RUN TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT TestAccTransfer_serial
=== RUN TestAccTransfer_serial/Server
=== RUN TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (208.81s)
--- PASS: TestAccTransfer_serial/Server (208.81s)
--- PASS: TestAccTransfer_serial/Server/basic (208.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 214.559s
% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/^DataSourceBasic$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run=TestAccTransfer_serial/Server/^DataSourceBasic$ -timeout 180m
=== RUN TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT TestAccTransfer_serial
=== RUN TestAccTransfer_serial/Server
=== RUN TestAccTransfer_serial/Server/DataSourceBasic
--- PASS: TestAccTransfer_serial (186.06s)
--- PASS: TestAccTransfer_serial/Server (186.06s)
--- PASS: TestAccTransfer_serial/Server/DataSourceBasic (186.06s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 191.781s
% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/^StructuredLogDestinations$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run=TestAccTransfer_serial/Server/^StructuredLogDestinations$ -timeout 180m
=== RUN TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT TestAccTransfer_serial
=== RUN TestAccTransfer_serial/Server
=== RUN TestAccTransfer_serial/Server/StructuredLogDestinations
--- PASS: TestAccTransfer_serial (210.04s)
--- PASS: TestAccTransfer_serial/Server (210.04s)
--- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (210.04s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 215.460s
@calvine Thanks for the contribution 🎉 👏. |
Happy to help @ewbankkit! I use terraform a lot! |
This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds support for the AWS Transfer Server Structured Logging Destinations property.
The AWS transfer module talks about this property here
Relations
Closes #32653
References
Here is some sample terraform that uses the new property and shows that the changes work, assuming that you are overriding the aws provider with the version built with this PRs code.
Output from Acceptance Testing
The acceptance test is working. Was not sure how to get computed value for testing the value in the structured log destinations, so write a function to test using terraform state. Please let me know if there was a better way to do what I wanted to do.