Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup/vault_policy: Improve diff handling for policies #28791

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 10, 2023

Description

Relations

Relates #23288

References

Output from Acceptance Testing

% make testacc TESTS=TestAccBackupVaultPolicy_ PKG=backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupVaultPolicy_'  -timeout 180m
=== RUN   TestAccBackupVaultPolicy_basic
=== PAUSE TestAccBackupVaultPolicy_basic
=== RUN   TestAccBackupVaultPolicy_disappears
=== PAUSE TestAccBackupVaultPolicy_disappears
=== RUN   TestAccBackupVaultPolicy_Disappears_vault
=== PAUSE TestAccBackupVaultPolicy_Disappears_vault
=== RUN   TestAccBackupVaultPolicy_ignoreEquivalent
=== PAUSE TestAccBackupVaultPolicy_ignoreEquivalent
=== CONT  TestAccBackupVaultPolicy_basic
=== CONT  TestAccBackupVaultPolicy_Disappears_vault
=== CONT  TestAccBackupVaultPolicy_disappears
=== CONT  TestAccBackupVaultPolicy_ignoreEquivalent
--- PASS: TestAccBackupVaultPolicy_Disappears_vault (14.93s)
--- PASS: TestAccBackupVaultPolicy_disappears (17.28s)
--- PASS: TestAccBackupVaultPolicy_ignoreEquivalent (24.10s)
--- PASS: TestAccBackupVaultPolicy_basic (30.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	35.154s

@YakDriver YakDriver added the service/backup Issues and PRs that pertain to the backup service. label Jan 10, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@YakDriver YakDriver added the size/XS Managed by automation to categorize the size of a PR. label Jan 10, 2023
@YakDriver YakDriver merged commit 7a7997f into main Jan 10, 2023
@YakDriver YakDriver deleted the b-backup-vault-policy branch January 10, 2023 16:05
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 10, 2023
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/backup Issues and PRs that pertain to the backup service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant