Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sesv2_configuration_set_event_destination: new resource #27565

Merged

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Oct 31, 2022

Description

This PR introduces the aws_sesv2_configuration_set_event_destination resource.

Relations

Relates #26796.
Closes #17570.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/Welcome.html

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccSESV2ConfigurationSetEventDestination_" PKG=sesv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2ConfigurationSetEventDestination_ -timeout 180m
=== RUN   TestAccSESV2ConfigurationSetEventDestination_basic
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_basic
=== RUN   TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_disappears
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_basic
=== CONT  TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (33.91s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_disappears
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (39.75s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_snsDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (15.79s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (35.82s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (31.90s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (484.78s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      536.477s

@kamilturek kamilturek changed the title F aws configuration set event destination r/aws_sesv2_configuration_set_event_destination: new resource Oct 31, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 31, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 1, 2022
@F21
Copy link
Contributor

F21 commented Dec 19, 2022

@kamilturek Any possibility this can be finished?

@kamilturek
Copy link
Collaborator Author

Hey @F21, I've been short on free time recently but I'll come back and finish it soon 👍

@kamilturek kamilturek force-pushed the f-aws-configuration-set-event-destination branch from 6d44848 to 0793c62 Compare January 1, 2023 14:45
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 9, 2023
@kamilturek kamilturek marked this pull request as ready for review January 9, 2023 22:28
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS="-run=TestAccSESV2ConfigurationSetEventDestination_" PKG=sesv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2ConfigurationSetEventDestination_ -timeout 180m
=== RUN   TestAccSESV2ConfigurationSetEventDestination_basic
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_basic
=== RUN   TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_disappears
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_basic
=== CONT  TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (26.30s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (27.54s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (22.21s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_disappears
--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (11.39s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_snsDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (24.09s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (268.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      301.046s

@jar-b jar-b merged commit d1d328d into hashicorp:main Jan 10, 2023
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 10, 2023
@jar-b
Copy link
Member

jar-b commented Jan 10, 2023

Thanks for your contribution @kamilturek!

Really impressive to get all of those destinations implemented together with full test coverage 👍

@kamilturek kamilturek deleted the f-aws-configuration-set-event-destination branch January 10, 2023 19:57
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SES v2 Delivery Delayed notifications
4 participants