Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_medialive_multiplex: add CRUD operations #26608

Merged
merged 14 commits into from
Sep 6, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Sep 1, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4936

Output from acceptance testing:

$ make testacc TESTS=TestAccMediaLiveMultiplex_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveMultiplex_'  -timeout 180m
=== RUN   TestAccMediaLiveMultiplex_basic
=== PAUSE TestAccMediaLiveMultiplex_basic
=== RUN   TestAccMediaLiveMultiplex_start
=== PAUSE TestAccMediaLiveMultiplex_start
=== RUN   TestAccMediaLiveMultiplex_update
=== PAUSE TestAccMediaLiveMultiplex_update
=== RUN   TestAccMediaLiveMultiplex_updateTags
=== PAUSE TestAccMediaLiveMultiplex_updateTags
=== RUN   TestAccMediaLiveMultiplex_disappears
=== PAUSE TestAccMediaLiveMultiplex_disappears
=== CONT  TestAccMediaLiveMultiplex_basic
=== CONT  TestAccMediaLiveMultiplex_update
=== CONT  TestAccMediaLiveMultiplex_start
=== CONT  TestAccMediaLiveMultiplex_updateTags
=== CONT  TestAccMediaLiveMultiplex_disappears
--- PASS: TestAccMediaLiveMultiplex_basic (57.43s)
--- PASS: TestAccMediaLiveMultiplex_update (96.74s)
--- PASS: TestAccMediaLiveMultiplex_updateTags (161.13s)
--- PASS: TestAccMediaLiveMultiplex_disappears (208.85s)
--- PASS: TestAccMediaLiveMultiplex_start (268.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	271.104s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/medialive Issues and PRs that pertain to the medialive service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Sep 1, 2022
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Sep 2, 2022
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. and removed sweeper Pertains to changes to or issues with the sweeper. labels Sep 2, 2022
@johnsonaj johnsonaj added new-resource Introduces a new resource. sweeper Pertains to changes to or issues with the sweeper. labels Sep 2, 2022
@johnsonaj johnsonaj marked this pull request as ready for review September 2, 2022 22:07
@ewbankkit
Copy link
Contributor

When running the acceptance tests I am getting continual HTTP 500 errors:

% make testacc TESTARGS='-run=TestAccMediaLiveMultiplex_basic' PKG=medialive ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 3  -run=TestAccMediaLiveMultiplex_basic -timeout 180m
=== RUN   TestAccMediaLiveMultiplex_basic
=== PAUSE TestAccMediaLiveMultiplex_basic
=== CONT  TestAccMediaLiveMultiplex_basic
    multiplex_test.go:30: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating AWS Elemental MediaLive Multiplex (tf-acc-test-2378415715046248013): operation error MediaLive: CreateMultiplex, exceeded maximum number of attempts, 25, https response error StatusCode: 500, RequestID: bbb44f48-a87f-4c33-a335-521f8fd9c12b, InternalServerErrorException: Internal Server Error
        
          with aws_medialive_multiplex.test,
          on terraform_plugin_test.tf line 6, in resource "aws_medialive_multiplex" "test":
           6: resource "aws_medialive_multiplex" "test" {
        
--- FAIL: TestAccMediaLiveMultiplex_basic (452.68s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	456.227s
FAIL
make: *** [testacc] Error 1

Any ideas?

@johnsonaj
Copy link
Contributor Author

@ewbankkit it seems like there is a limit of 2 multiplexes per region but that still odd that it fails when you try to run just one test: https://docs.aws.amazon.com/general/latest/gr/medialive_region.html

I've changed these test to run serial instead of parallel to see if that helps

$ make testacc TESTS=TestAccMediaLive_serial PKG=medialive                                                                             130 ↵
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLive_serial'  -timeout 180m
=== RUN   TestAccMediaLive_serial
=== RUN   TestAccMediaLive_serial/Multiplex
=== RUN   TestAccMediaLive_serial/Multiplex/basic
=== RUN   TestAccMediaLive_serial/Multiplex/disappears
=== RUN   TestAccMediaLive_serial/Multiplex/update
=== RUN   TestAccMediaLive_serial/Multiplex/updateTags
=== RUN   TestAccMediaLive_serial/Multiplex/start
--- PASS: TestAccMediaLive_serial (558.09s)
    --- PASS: TestAccMediaLive_serial/Multiplex (558.09s)
        --- PASS: TestAccMediaLive_serial/Multiplex/basic (61.12s)
        --- PASS: TestAccMediaLive_serial/Multiplex/disappears (72.81s)
        --- PASS: TestAccMediaLive_serial/Multiplex/update (97.38s)
        --- PASS: TestAccMediaLive_serial/Multiplex/updateTags (89.76s)
        --- PASS: TestAccMediaLive_serial/Multiplex/start (237.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	564.308s

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMediaLive_serial/Multiplex' PKG=medialive  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLive_serial/Multiplex -timeout 180m
=== RUN   TestAccMediaLive_serial
=== RUN   TestAccMediaLive_serial/Multiplex
=== RUN   TestAccMediaLive_serial/Multiplex/updateTags
=== RUN   TestAccMediaLive_serial/Multiplex/start
=== RUN   TestAccMediaLive_serial/Multiplex/basic
=== RUN   TestAccMediaLive_serial/Multiplex/disappears
=== RUN   TestAccMediaLive_serial/Multiplex/update
--- PASS: TestAccMediaLive_serial (592.09s)
    --- PASS: TestAccMediaLive_serial/Multiplex (592.09s)
        --- PASS: TestAccMediaLive_serial/Multiplex/updateTags (84.87s)
        --- PASS: TestAccMediaLive_serial/Multiplex/start (284.10s)
        --- PASS: TestAccMediaLive_serial/Multiplex/basic (61.76s)
        --- PASS: TestAccMediaLive_serial/Multiplex/disappears (57.25s)
        --- PASS: TestAccMediaLive_serial/Multiplex/update (104.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	596.208s

@johnsonaj johnsonaj merged commit 50e69d5 into main Sep 6, 2022
@johnsonaj johnsonaj deleted the f-aws_medialive_multiplex branch September 6, 2022 18:12
@github-actions github-actions bot added this to the v4.30.0 milestone Sep 6, 2022
github-actions bot pushed a commit that referenced this pull request Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This functionality has been released in v4.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/medialive Issues and PRs that pertain to the medialive service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants