r/vpc_ipam_scope: prevent panic and add pagination when describing existing scopes by ID

.changelog/24188.txt

@@ -0,0 +1,7 @@
+```release-note:bug
+resource/aws_vpc_ipam_scope: Prevent panic when describing IPAM Scopes by ID
+```
+
+```release-note:enhancement
+resource/aws_vpc_ipam_scope: Add pagination when describing IPAM Scopes
+```

internal/service/ec2/vpc_ipam_scope.go

@@ -109,18 +109,28 @@ func ResourceVPCIpamScopeRead(d *schema.ResourceData, meta interface{}) error {
 	ignoreTagsConfig := meta.(*conns.AWSClient).IgnoreTagsConfig
 
 	scope, err := findIpamScopeById(conn, d.Id())
-	ipamId := strings.Split(*scope.IpamArn, "/")[1]
 
-	if err != nil && !tfawserr.ErrCodeEquals(err, InvalidIpamScopeIdNotFound) {
-		return err
+	if !d.IsNewResource() && tfresource.NotFound(err) {
+		log.Printf("[WARN] IPAM Scope (%s) not found, removing from state", d.Id())
+		d.SetId("")
+		return nil
+	}
+
+	if err != nil {
+		return fmt.Errorf("error reading IPAM Scope (%s): %w", d.Id(), err)
 	}
 
-	if !d.IsNewResource() && scope == nil {
+	if scope == nil {
+		if d.IsNewResource() {
+			return fmt.Errorf("error reading IPAM Scope (%s): not found after creation", d.Id())
+		}
 		log.Printf("[WARN] IPAM Scope (%s) not found, removing from state", d.Id())
 		d.SetId("")
 		return nil
 	}
 
+	ipamId := strings.Split(aws.StringValue(scope.IpamArn), "/")[1]
+
 	d.Set("arn", scope.IpamScopeArn)
 	d.Set("description", scope.Description)
 	d.Set("ipam_arn", scope.IpamArn)
@@ -199,17 +209,44 @@ func findIpamScopeById(conn *ec2.EC2, id string) (*ec2.IpamScope, error) {
 		IpamScopeIds: aws.StringSlice([]string{id}),
 	}
 
-	output, err := conn.DescribeIpamScopes(input)
+	var results []*ec2.IpamScope
+
+	err := conn.DescribeIpamScopesPages(input, func(page *ec2.DescribeIpamScopesOutput, lastPage bool) bool {
+		if page == nil {
+			return !lastPage
+		}
+
+		for _, scope := range page.IpamScopes {
+			if scope == nil {
+				continue
+			}
+
+			results = append(results, scope)
+		}
+
+		return !lastPage
+	})
+
+	if tfawserr.ErrCodeEquals(err, InvalidIpamScopeIdNotFound) {
+		return nil, &resource.NotFoundError{
+			LastError:   err,
+			LastRequest: input,
+		}
+	}
 
 	if err != nil {
 		return nil, err
 	}
 
-	if output == nil || len(output.IpamScopes) == 0 || output.IpamScopes[0] == nil {
-		return nil, nil
+	if len(results) == 0 {
+		return nil, tfresource.NewEmptyResultError(input)
+	}
+
+	if count := len(results); count > 1 {
+		return nil, tfresource.NewTooManyResultsError(count, input)
 	}
 
-	return output.IpamScopes[0], nil
+	return results[0], nil
 }
 
 func waitIpamScopeAvailable(conn *ec2.EC2, ipamScopeId string, timeout time.Duration) (*ec2.IpamScope, error) {