Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Providers with ProviderFactories in s3_bucket_object: ignoreTags #17716

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

gunadhya
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #17599

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@gunadhya gunadhya requested a review from a team as a code owner February 19, 2021 19:10
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 19, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 19, 2021
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 19, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, @gunadhya 🚀

Output from acceptance testing locally in parallel:

--- PASS: TestAccAWSS3BucketObject_acl (92.39s)
--- PASS: TestAccAWSS3BucketObject_content (31.76s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (29.61s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (41.81s)
--- PASS: TestAccAWSS3BucketObject_empty (30.09s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (35.67s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (66.50s)
--- PASS: TestAccAWSS3BucketObject_kms (39.66s)
--- PASS: TestAccAWSS3BucketObject_metadata (72.05s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (5.56s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (92.30s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (66.45s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (87.19s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (107.49s)
--- PASS: TestAccAWSS3BucketObject_source (33.71s)
--- PASS: TestAccAWSS3BucketObject_sse (38.85s)
--- PASS: TestAccAWSS3BucketObject_storageClass (132.95s)
--- PASS: TestAccAWSS3BucketObject_tags (115.23s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (115.23s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (110.19s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (114.35s)
--- PASS: TestAccAWSS3BucketObject_updates (69.28s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (68.48s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (70.03s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (71.18s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (30.44s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (1.09s)

@bflad bflad merged commit 18547c8 into hashicorp:main Feb 19, 2021
@ghost
Copy link

ghost commented Mar 22, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/s3_bucket_object: ignoreTags acceptance test fails locally in parallel
2 participants