Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix in resource aws_msk_cluster enhanced_monitoring PER_TOPIC_PER_PARTITION #16914

Merged
merged 2 commits into from
Jan 5, 2021
Merged

fix in resource aws_msk_cluster enhanced_monitoring PER_TOPIC_PER_PARTITION #16914

merged 2 commits into from
Jan 5, 2021

Conversation

gunadhya
Copy link
Contributor

@gunadhya gunadhya commented Dec 28, 2020 •
edited by anGie44
Loading

Added the use of AWS Go SDK _Values() in enhanced_monitoring and client_broker in resource_aws_msk_cluster.go

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16866
Relates #14601
Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@gunadhya gunadhya requested a review from a team as a code owner December 28, 2020 11:30
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/kafka Issues and PRs that pertain to the kafka service. labels Dec 28, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 28, 2020
@gunadhya gunadhya closed this Dec 28, 2020
@gunadhya gunadhya reopened this Dec 28, 2020
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 4, 2021
anGie44
anGie44 suggested changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gunadhya, thank you for this PR! Looks great overall, just one small request to restore the tools/go.mod and go.sum files as I believe they should not need to be updated for this change

@gunadhya gunadhya requested a review from anGie44 January 4, 2021 20:38
anGie44
anGie44 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @gunadhya 🚀 🚀

@anGie44 anGie44 added this to the v3.23.0 milestone Jan 5, 2021
@anGie44 anGie44 merged commit f24f66d into hashicorp:master Jan 5, 2021
anGie44 added a commit that referenced this pull request Jan 5, 2021
@anGie44
Update CHANGELOG for #16914
06fe750
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.23.0
Development

Successfully merging this pull request may close these issues.

resource aws_msk_cluster enhanced_monitoring does not allow setting to PER_TOPIC_PER_PARTITION
2 participants
@gunadhya @anGie44