Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Consolidate ENI Describe/Detach/Delete calls #10363

Closed
ewbankkit opened this issue Oct 3, 2019 · 4 comments
Closed

Tech debt: Consolidate ENI Describe/Detach/Delete calls #10363

ewbankkit opened this issue Oct 3, 2019 · 4 comments
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Oct 3, 2019 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As noted by @obourdon in this comment, #10114 and #10347 introduced new routines to describe, detach and delete ENIs.
There are multiple other locations throughout the code that make similar calls.
We should consider consolidating on a single set of routines that perform these actions.

New or Affected Resource(s)

  • aws_elb
  • aws_internet_gateway
  • aws_lb
  • aws_network_interface
  • aws_network_interface_attachment
  • aws_network_interface_sg_attachment

Potential Terraform Configuration

n/a

References
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 3, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 3, 2019
@ewbankkit ewbankkit changed the title Tech debt: Tech debt: Consolidate ENI Describe/Detach/Delete calls Oct 3, 2019
@ghost ghost added service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Oct 3, 2019
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Feb 5, 2020
@VanWolf29
Copy link

I can take this ticket.

@VanWolf29
Copy link

Can I have some more background on this issue so that I can start working please?

bflad added a commit that referenced this issue Mar 29, 2021
@bflad
resource/aws_network_interface_sg_attachment: Handle read-after-creat…
52a6261 
…e eventual consistency

Reference: #10363
Reference: #16201
Reference: #16796

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (59.24s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (59.57s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (63.42s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (93.21s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (105.56s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (61.51s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (62.15s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (65.05s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (93.55s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (114.74s)
```
@bflad bflad mentioned this issue Mar 29, 2021
Merged
bflad added a commit that referenced this issue Apr 1, 2021
@bflad
resource/aws_network_interface_sg_attachment: Handle read-after-creat…
067b8fe 
…e eventual consistency (#18466)

* resource/aws_network_interface_sg_attachment: Handle read-after-create eventual consistency

Reference: #10363
Reference: #16201
Reference: #16796

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (59.24s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (59.57s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (63.42s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (93.21s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (105.56s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (61.51s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (62.15s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (65.05s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (93.55s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (114.74s)
```

* Update CHANGELOG for #18466
@ewbankkit
Copy link
Contributor Author

Closing in favor of #21406.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bflad @ewbankkit @VanWolf29