-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech debt: Consolidate ENI Describe/Detach/Delete calls #10363
Comments
I can take this ticket. |
Can I have some more background on this issue so that I can start working please? |
…e eventual consistency Reference: #10363 Reference: #16201 Reference: #16796 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (59.24s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (59.57s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (63.42s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (93.21s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (105.56s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (61.51s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (62.15s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (65.05s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (93.55s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (114.74s) ```
…e eventual consistency (#18466) * resource/aws_network_interface_sg_attachment: Handle read-after-create eventual consistency Reference: #10363 Reference: #16201 Reference: #16796 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (59.24s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (59.57s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (63.42s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (93.21s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (105.56s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (61.51s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (62.15s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (65.05s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (93.55s) --- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (114.74s) ``` * Update CHANGELOG for #18466
Closing in favor of #21406. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Description
As noted by @obourdon in this comment, #10114 and #10347 introduced new routines to describe, detach and delete ENIs.
There are multiple other locations throughout the code that make similar calls.
We should consider consolidating on a single set of routines that perform these actions.
New or Affected Resource(s)
aws_elb
aws_internet_gateway
aws_lb
aws_network_interface
aws_network_interface_attachment
aws_network_interface_sg_attachment
Potential Terraform Configuration
n/a
References
The text was updated successfully, but these errors were encountered: