Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Module to Go 1.20 Minimum #188

Closed
bflad opened this issue Sep 6, 2023 · 1 comment · Fixed by #189
Closed

Update Go Module to Go 1.20 Minimum #188

bflad opened this issue Sep 6, 2023 · 1 comment · Fixed by #189
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Sep 6, 2023

Use cases

Following the Go support policy and given the ecosystem availability of the latest Go minor version, it's time to upgrade. This will ensure that this project can use recent improvements to the Go runtime, standard library functionality, and continue to receive security updates.

Proposal

  • Run the following commands to upgrade the Go module files and automatically fix outdated Go code:
go mod edit -go=1.20
go mod tidy
go fix ./...
cd tools
go mod edit -go=1.20
go mod tidy
  • Ensure any GitHub Actions workflows (.github/workflows/*.yml) use 1.21 in place of any 1.20 and 1.20 in place of any 1.19 or earlier
  • Ensure the README or any Contributing documentation notes the Go 1.20 expected minimum

References

@bflad bflad added the enhancement New feature or request label Sep 6, 2023
@bflad bflad added this to the v0.12.0 milestone Sep 6, 2023
@bflad bflad self-assigned this Sep 6, 2023
bflad added a commit that referenced this issue Sep 6, 2023
@bflad bflad closed this as completed in #189 Sep 6, 2023
bflad added a commit that referenced this issue Sep 6, 2023
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant