-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move debug logs to trace #710
Conversation
Hi @trodge 👋 Thank you for submitting this. While the maintainers generally agree that some of the logging (e.g. schema-based logic handoffs to provider-defined code) is likely a good candidate for log level demotion now that the framework code has stabilized since v1.0.0, per our contributing guidelines it feels like this type of developer-affecting change should be advertised and discussed in an issue first. We'll likely need to publish (and potentially try to enforce) the updated guidelines for logging levels as part of this, since the current precedent is that all handoffs to provider-defined logic should be DEBUG level. Thank you again. |
Please note that in the meantime, you may be able to tune your logging by setting the environment variable |
Could that target be added to https://developer.hashicorp.com/terraform/internals/debugging? We'd been trying to limit the log noise and found that these logs were coming through based on the |
@rileykarson https://developer.hashicorp.com/terraform/plugin/log/managing has information about environment variables on the provider side of the protocol (at least for HashiCorp maintained projects), although I do see its missing |
Reference: hashicorp/terraform-plugin-framework#710 (comment) The goal here is to not burden the Terraform documentation with all the logging implementation details from the provider side of the protocol, but ensure the information is at least more discoverable.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
These messages are appearing in our logs during acceptance test runs and make up the majority of the log without providing much information. We would prefer if they were logged at a lower level.