Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting VERSION from version.go in makefile #609

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix getting VERSION from version.go in makefile #609

merged 1 commit into from
Jul 27, 2021

Conversation

bayandin
Copy link
Contributor

@bayandin bayandin commented Jul 24, 2020 •
edited
Loading

Currently make dist fails because it can't find file cmd/serf/version.go:

$ make dist
awk: can't open file cmd/serf/version.go
 source line number 1
Please specify a version.
make: *** [dist] Error 1

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 24, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bayandin bayandin changed the title Fix path to version.go in makefile Fix getting VERSION from version.go in makefile Jul 24, 2020
markan
markan approved these changes Jul 27, 2021
View reviewed changes
Copy link

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@markan markan merged commit b6b1e3d into hashicorp:master Jul 27, 2021
@bayandin bayandin deleted the patch-1 branch July 28, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markan markan markan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bayandin @hashicorp-cla @markan