Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update nomad dependency to v1.6.0-beta.1 #266

Merged
merged 1 commit into from
Jul 7, 2023
Merged

deps: update nomad dependency to v1.6.0-beta.1 #266

merged 1 commit into from
Jul 7, 2023

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Jul 6, 2023 •
edited
Loading

Should hopefully fix the CGO problem in #227

@shoenig
deps: update nomad dependency to v1.6.0-beta.1
1d8c1b9 
Should hopefully fix the CGO problem.
lgfa29
lgfa29 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to test this, but if you need something to smoke test I built some binaries from this branch:
https://github.com/hashicorp/nomad-driver-podman/actions/runs/5480372129

@shoenig
Copy link
Member Author

shoenig commented Jul 7, 2023

@jdoss if you have access to the artifacts in ^, mind trying against Fedora CoreOS?

@shoenig shoenig merged commit 6faa2ae into main Jul 7, 2023
13 checks passed
@shoenig shoenig deleted the deps-update-nomad branch July 7, 2023 12:47
@jdoss
Copy link
Contributor

jdoss commented Jul 8, 2023 •
edited
Loading

@shoenig I was able to test this out this evening on a client node running on Fedora CoreOS 38.20230609.3.0 and it worked as expected! Thank you for fixing this. 😄

@Procsiab
Copy link
Contributor

I am happy to report the successful loading of this build of the plugin, on a Fedora IoT 38.20230630.0 system. I also tested the ARM64 binary on a Raspberry Pi, with the same OS deployment version, and it is working.
Thanks to all of you for helping in resolving this ❤️

@Procsiab Procsiab mentioned this pull request Jul 10, 2023
Closed
@ahjohannessen
Copy link

@shoenig Is a 0.4.3 with this fix soon released?

@shoenig
Copy link
Member Author

shoenig commented Jul 17, 2023

We'll do a Podman v0.5.0 release as soon as we have Nomad v1.6 GA, which should be in the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

@jrasell jrasell Awaiting requested review from jrasell

@towe75 towe75 Awaiting requested review from towe75

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shoenig @jdoss @Procsiab @ahjohannessen @lgfa29