Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for an extra_labels stanza similar to the Docker driver #215

Merged
merged 3 commits into from
Mar 11, 2023

Conversation

rbarry82
Copy link
Contributor

Log collection in observability stacks (such as via Vector) when using the podman driver isn't as literate as Docker.

Add the option to add extra labels so promtail/vector/filebeat/whatever can get a view of what Nomad-related things running Podman containers may be doing.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for the PR @rbarry82!

I pushed a commit to remove an extra defer call from test and also to add a CHANGELOG.md entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants