Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic discovered while fuzzing #11

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Fix panic discovered while fuzzing #11

merged 1 commit into from
Jan 19, 2016

Conversation

pcasaretto
Copy link
Contributor

OK, now for a real PR!

While fuzzing the library I discovered that this specific panic might happen when an input containing a big version number was given.

panic: Error parsing version: strconv.ParseInt: parsing "11387778780781445675529500000000000000000": value out of range

goroutine 1 [running]:
github.com/hashicorp/go-version.parseSingle(0xc820014870, 0x29, 0x1, 0x0, 0x0)
    /var/folders/27/yjth92qs63g482k53zhr_hb80000gn/T/go-fuzz-build816843738/src/github.com/hashicorp/go-version/constraint.go:108 +0x33c

@mitchellh
Copy link
Contributor

Wow, right you are. Thanks

mitchellh added a commit that referenced this pull request Jan 19, 2016
@mitchellh
Merge pull request #11 from pcasaretto/fuzzing
400e66d 
Fix panic discovered while fuzzing
@mitchellh mitchellh merged commit 400e66d into hashicorp:master Jan 19, 2016
@pcasaretto pcasaretto deleted the fuzzing branch January 19, 2016 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcasaretto @mitchellh