Expose Runner interface to allow custom command runner implementations #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Runner can be supplied by new config field RunnerFunc * Also adds SkipHostEnv config option * Adds optional environment variables to control plugin's unix socket * Adds CmdRunner as the default Runner implementation, maintaining existing functionality
|
hashicorp/go-secure-stdlib#84 has an alternative container-based implementation for any reviewers who'd like to compare with |
fairclothjm
reviewed
Aug 21, 2023
swenson
approved these changes
Aug 22, 2023
|
Thanks! |
tomhjp
added a commit
that referenced
this pull request
Aug 24, 2023
A set of small follow-ups to #270: * Make config.Cmd and config.RunnerFunc mutually exclusive * Explicitly mark ReattachConfig as unsupported for RunnerFunc clients * Improve 1 logger line for non-cmd implementations
tomhjp
added a commit
that referenced
this pull request
Aug 24, 2023
A set of small follow-ups to #270: * Make config.Cmd and config.RunnerFunc mutually exclusive * Explicitly mark ReattachConfig as unsupported for RunnerFunc clients * Improve 1 logger line for non-cmd implementations * Add ID() function to client, useful for client's debug log information
tomhjp
added a commit
that referenced
this pull request
Aug 24, 2023
A set of small follow-ups to #270: * Make config.Cmd and config.RunnerFunc mutually exclusive * Clients setting RunnerFunc can call ReattachConfig but need to supply their own ReattachFunc as it can't necessarily be derived from RunnerFunc. * Improve 1 logger line for non-cmd implementations * Add ID() function to client, useful for client's debug log information
tomhjp
added a commit
that referenced
this pull request
Aug 24, 2023
A set of small follow-ups to #270: * Make `config.Cmd` and `config.RunnerFunc` mutually exclusive. * Clients setting `RunnerFunc` can call `ReattachConfig` but need to supply their own `ReattachFunc` as it can't necessarily be derived from `RunnerFunc`. Exercise `ReattachConfig()` in tests in a way that previously panicked. * Improve 1 logger line for non-cmd implementations. * Add `ID()` function to client; allows clients to construct a `ReattachFunc` and also useful for client's debug log information.
tomhjp
added a commit
that referenced
this pull request
Aug 24, 2023
A set of small follow-ups to #270: * Make `config.Cmd` and `config.RunnerFunc` mutually exclusive. * Clients setting `RunnerFunc` can call `ReattachConfig` but need to supply their own `ReattachFunc` as it can't necessarily be derived from `RunnerFunc`. Exercise `ReattachConfig()` in tests in a way that previously panicked. * Improve 1 logger line for non-cmd implementations. * Add `ID()` function to client; allows clients to construct a `ReattachFunc` and also useful for client's debug log information.
tomhjp
added a commit
that referenced
this pull request
Aug 25, 2023
A set of small follow-ups to #270: * Make `ClientConfig.Cmd` and `ClientConfig.RunnerFunc` mutually exclusive * Clients setting `RunnerFunc` can call `ReattachConfig()` but need to supply their own `ReattachFunc` as it can't necessarily be derived from `RunnerFunc`. Exercise `ReattachConfig()` in tests in a way that previously panicked. * Improve 1 logger line for non-cmd implementations. * Add `ID()` function to client; accommodates creating a `ReattachFunc` and also useful for client's debug log information.
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runnerpackage to allow custom implementations for running plugins.RunnerFunccan be supplied to customise how a plugin is run, with*exec.Cmdtreated as the spec.SkipHostEnvtells go-plugin not to add the host process' environment variables to the command spec. Closes allow starting plugin without the host environment variables #104 and closes Allow overriding ambient environment variables #163ReattachConfig.ReattachFunccan be supplied to hook into running plugins that are identified by something other than a process IDSee hashicorp/go-secure-stdlib#84 for an example implementation of
runner's interfaces.Not planned (for now):