Add port of url.Redact to satisfy go1.14 compatibility #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eculver
requested review from
mitchellh,
azr,
mikemorris,
freddygv and
kisunji
picatz
reviewed
Aug 26, 2021
Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
picatz
reviewed
Aug 26, 2021
…into go1.14-compat
Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
picatz
approved these changes
Aug 26, 2021
azr
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our Consul 1.8.x release series, we depend on support for go1.14 and we depend on
go-gettertransitively through Nomad. After some looking, it appears that the only compatibility issue stems from the use of"net/url".URL.Redactedwhich was added in go1.15. So, this adds agetter.RedactURLmethod with the same functionality.This won't block us or anything, but it would be real nice to be compatible with go1.14 given that it's just this one method.