Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Add consul.json in entrypoint by envorinment variable #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prates
Copy link

@prates prates commented Sep 18, 2020

Write file a basic config/consul.json with environment variable. This make more easy enable ACL in helm chart.

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


EC2 Default User seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@dhiaayachi
Copy link

Hi @prates, Thank you for adding this and I'm sorry for the long time it took.

Can you please tell me more about the use case(s) that this will cover. From our perspective adding a number of environment variable which don't cover all of consul config is inconsistent.

From my understanding you still can achieve what this aim for in 3 possible ways:

  • use consul agent command -hcl flag to pass config snippets using environment variables when starting the container
  • Generate/Create a config file on the host base on the environment variable and mount it when starting the container
  • Write a custom entrypoint and inject it at run time

Let me know if these are good alternatives

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants