Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added configuration option for allocating HBar for a test run. #3013

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ebadiere
Copy link
Collaborator

Added configuration option for HBar required in the relay operator balance to run a given test suite

Fixes #3007

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere added the enhancement New feature or request label Sep 18, 2024
@ebadiere ebadiere added this to the 0.57.0 milestone Sep 18, 2024
@ebadiere ebadiere self-assigned this Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Tests

       3 files     297 suites   19s ⏱️
1 353 tests 1 352 ✔️ 1 💤 0
1 362 runs  1 361 ✔️ 1 💤 0

Results for commit 88a8b23.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 18, 2024

Acceptance Tests

  18 files  232 suites   31m 48s ⏱️
604 tests 588 ✔️ 4 💤 12
770 runs  754 ✔️ 4 💤 12

Results for commit bec55e2.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for naming and explanation

docs/configuration.md Outdated Show resolved Hide resolved
Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Nana-EC
Nana-EC previously approved these changes Sep 18, 2024
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
…graph/hedera-json-rpc-relay into 3007-configure-test-balance

Signed-off-by: ebadiere <ebadiere@gmail.com>
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled should execute "eth_getTransactionByHash with missing transaction". This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 32,703.7 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.05 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: increased with 1.05 MB
  • Total Available Size: decreased with 2.26 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 128.00 bytes
  • Used Heap Size: decreased with 2.53 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:
    • Space Size: increased with 1.05 MB
    • Space Used Size: increased with 584.98 KB
    • Space Available Size: decreased with 3.07 MB
    • Physical Space Size: increased with 1.05 MB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (7363c96) to head (88a8b23).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3013      +/-   ##
==========================================
- Coverage   89.92%   89.92%   -0.01%     
==========================================
  Files          58       58              
  Lines        3900     3899       -1     
  Branches      780      780              
==========================================
- Hits         3507     3506       -1     
  Misses        346      346              
  Partials       47       47              
Flag Coverage Δ
relay 90.14% <ø> (-0.01%) ⬇️
server 88.15% <ø> (ø)
ws-server 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Configure the test balance to be variable when running the acceptance test suite.
4 participants