-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Disable spending history of HbarSpendingPlans #2997
Conversation
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Feel free to make sure design doc or others captures the potential ideas for this so it's there should we come back to it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
==========================================
+ Coverage 89.18% 90.48% +1.29%
==========================================
Files 54 59 +5
Lines 3783 3984 +201
Branches 774 816 +42
==========================================
+ Hits 3374 3605 +231
+ Misses 362 330 -32
- Partials 47 49 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
It's not clear yet if the spending history of the plans is going to be used for anything and it will consume a lot of the cache's memory so it's better to keep it empty for now.
Changes:
HbarSpendingPlanRepository#getSpendingHistory
HbarSpendingPlanRepository#addAmountToSpendingHistory
Related issue(s):
Fixes #2994
Notes for reviewer:
Checklist