Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable spending history of HbarSpendingPlans #2997

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

victor-yanev
Copy link
Contributor

Description:

It's not clear yet if the spending history of the plans is going to be used for anything and it will consume a lot of the cache's memory so it's better to keep it empty for now.

Changes:

  • Removed all usages of HbarSpendingPlanRepository#getSpendingHistory
  • Removed all usages of HbarSpendingPlanRepository#addAmountToSpendingHistory

Related issue(s):

Fixes #2994

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
@victor-yanev victor-yanev added this to the 0.57.0 milestone Sep 17, 2024
@victor-yanev victor-yanev self-assigned this Sep 17, 2024
@victor-yanev victor-yanev changed the title chore: Disable spending history chore: Disable spending history of HbarSpendingPlans Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

Tests

       3 files     284 suites   19s ⏱️
1 317 tests 1 316 ✔️ 1 💤 0
1 329 runs  1 328 ✔️ 1 💤 0

Results for commit e6c3aa0.

Copy link

Acceptance Tests

  18 files  257 suites   30m 12s ⏱️
604 tests 596 ✔️ 4 💤 4
809 runs  799 ✔️ 6 💤 4

Results for commit e6c3aa0.

@victor-yanev victor-yanev added the enhancement New feature or request label Sep 17, 2024
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Feel free to make sure design doc or others captures the potential ideas for this so it's there should we come back to it

@victor-yanev victor-yanev merged commit 99ea48f into main Sep 19, 2024
40 of 44 checks passed
@victor-yanev victor-yanev deleted the 2994-disable-spending-history branch September 19, 2024 13:48
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (e54bb85) to head (e6c3aa0).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
+ Coverage   89.18%   90.48%   +1.29%     
==========================================
  Files          54       59       +5     
  Lines        3783     3984     +201     
  Branches      774      816      +42     
==========================================
+ Hits         3374     3605     +231     
+ Misses        362      330      -32     
- Partials       47       49       +2     
Flag Coverage Δ
relay 89.59% <ø> (-0.01%) ⬇️
server 88.15% <ø> (+0.89%) ⬆️
ws-server 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sitories/hbarLimiter/hbarSpendingPlanRepository.ts 100.00% <ø> (ø)
...s/relay/src/lib/services/hbarLimitService/index.ts 95.95% <ø> (-0.05%) ⬇️

... and 13 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HBAR Rate Limit Redesign] Disable spending history
3 participants