fix: included call.from to the cacheKey in callConsensusNode()
#2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
|
quiet-node
deleted the
2992-relay-returned-wrong-cached-value-for-hrc719isassociated
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
==========================================
+ Coverage 89.18% 89.47% +0.28%
==========================================
Files 54 56 +2
Lines 3783 3830 +47
Branches 774 782 +8
==========================================
+ Hits 3374 3427 +53
+ Misses 362 356 -6
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR simply adds the call.from to the cacheKey in callConsensusNode() as certain requests (e.g., HRC719.isAssociated()) require call.from as an additional specifier to ensure more accurate cached values.
Related issue(s):
Fixes #2992
Notes for reviewer:
Checklist