feat: add ipAddressHbarSpendingPlan #2913
Merged
+614
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> # Conflicts: # package-lock.json
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Ivo-Yankov
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
victor-yanev
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Looks good, please point this branch to 2901-Implement-add-expense and resolve the TODOs which are mentioning the #2888 issue
packages/relay/src/lib/db/repositories/hbarLimiter/ipAddressHbarSpendingPlanRepository.ts
Show resolved
Hide resolved
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
…ddress-limiting-2
victor-yanev
previously approved these changes
Sep 9, 2024
…ddress-limiting-2
…ddress-limiting-2
…ddress-limiting-2
…ddress-limiting-2
quiet-node
previously approved these changes
Sep 10, 2024
packages/relay/tests/lib/repositories/hbarLimiter/ethAddressHbarSpendingPlanRepository.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/repositories/hbarLimiter/ipAddressHbarSpendingPlanRepository.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Ivo-Yankov
dismissed stale reviews from quiet-node and victor-yanev
via
d674d71
victor-yanev
previously approved these changes
Sep 10, 2024
packages/relay/tests/lib/repositories/hbarLimiter/ipAddressHbarSpendingPlanRepository.spec.ts
Outdated
Show resolved
Hide resolved
…ddress-limiting-2
Co-authored-by: Victor Yanev <161485803+victor-yanev@users.noreply.github.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
…ddress-limiting-2
…ddress-limiting-2 Signed-off-by: ebadiere <ebadiere@gmail.com>
…ddress-limiting-2 Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> # Conflicts: # packages/relay/src/lib/services/hbarLimitService/index.ts # packages/relay/tests/lib/services/hbarLimitService/hbarLimitService.spec.ts
victor-yanev
requested review from
victor-yanev,
konstantinabl and
quiet-node
…ddress-limiting-2 Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
|
konstantinabl
approved these changes
Sep 17, 2024
victor-yanev
approved these changes
Sep 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
+ Coverage 89.18% 89.56% +0.37%
==========================================
Files 54 58 +4
Lines 3783 3863 +80
Branches 774 782 +8
==========================================
+ Hits 3374 3460 +86
+ Misses 362 356 -6
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
victor-yanev
deleted the
2888-hbar-rate-limit-redesign-implement-ip-address-limiting-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds clasees for limiting operator hbar usage by IP address.
Related issue(s):
Fixes #2888
Notes for reviewer:
Checklist