fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE #2698

Ivo-Yankov · 2024-07-12T13:57:31Z

Description:

Replaces .execute() with .executeAll() for fileAppendTransaciton. This way all transactions are returned in the result. The transaction_fee is summed and subtracted from the remaining Hbar limit in the limiter class.
Removes some unused functions from sdkClient.ts.
Adds additional acceptance tests for HbarLimiter.
Changes the relay operator when running acceptance tests to one of the local-node generated accounts.

Related issue(s):

Fixes #2693

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

github-actions · 2024-07-12T14:09:26Z

Tests

    2 files 161 suites 12s ⏱️
866 tests 865 ✔️ 1 💤 0 ❌
879 runs 878 ✔️ 1 💤 0 ❌

Results for commit 4b670dc.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-12T14:48:47Z

Acceptance Tests

  17 files 213 suites 32m 8s ⏱️
609 tests 603 ✔️ 4 💤 2 ❌
644 runs 638 ✔️ 4 💤 2 ❌

Results for commit 4b670dc.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

quiet-node

LGTM

Nana-EC

Great ideas.
Some questions and clarifications

package.json

packages/relay/src/lib/clients/sdkClient.ts

packages/server/tests/acceptance/rateLimiter.spec.ts

packages/server/tests/clients/metricsClient.ts

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

ebadiere

LG.

Nana-EC

LG, unblocking
Minor suggestions

packages/server/tests/acceptance/index.spec.ts

packages/server/tests/clients/metricsClient.ts

packages/server/tests/localAcceptance.env

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

package.json

Nana-EC

Unblocking but see minor items before merge

package.json

packages/relay/src/lib/clients/sdkClient.ts

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

sonarcloud · 2024-07-17T16:51:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

quiet-node

LGTM

…CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: fix typo Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: code smell Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set lower hbar limit for acceptance tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: addressing comments Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set operator key Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: check if switching operator in relay restart breaks sdkClient Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: remove .only Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: change operator for all tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: reverted an unwanted change Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend * chore: code cleanup * chore: fix typo * nit: code smell * fix: set lower hbar limit for acceptance tests * fix: addressing comments * fix: set operator key * test: check if switching operator in relay restart breaks sdkClient * chore: remove .only * fix: change operator for all tests * chore: reverted an unwanted change --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: Ivo Yankov <ivo@devlabs.bg>

…CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: fix typo Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: code smell Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set lower hbar limit for acceptance tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: addressing comments Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set operator key Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: check if switching operator in relay restart breaks sdkClient Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: remove .only Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: change operator for all tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: reverted an unwanted change Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend * chore: code cleanup * chore: fix typo * nit: code smell * fix: set lower hbar limit for acceptance tests * fix: addressing comments * fix: set operator key * test: check if switching operator in relay restart breaks sdkClient * chore: remove .only * fix: change operator for all tests * chore: reverted an unwanted change --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: Ivo Yankov <ivo@devlabs.bg>

…CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: fix typo Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: code smell Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set lower hbar limit for acceptance tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: addressing comments Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set operator key Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: check if switching operator in relay restart breaks sdkClient Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: remove .only Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: change operator for all tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: reverted an unwanted change Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: use executeAll for fileAppend

b43f000

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov requested review from AlfredoG87, ebadiere, Nana-EC, a team and lukelee-sl as code owners July 12, 2024 13:57

Ivo-Yankov marked this pull request as draft July 12, 2024 13:57

Ivo-Yankov self-assigned this Jul 12, 2024

Ivo-Yankov added bug Something isn't working enhancement New feature or request labels Jul 12, 2024

Ivo-Yankov added this to the 0.53.0 milestone Jul 15, 2024

Ivo-Yankov added 4 commits July 15, 2024 13:41

chore: code cleanup

56e7c14

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

chore: fix typo

7c69fce

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

nit: code smell

10bf983

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

fix: set lower hbar limit for acceptance tests

066df23

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov marked this pull request as ready for review July 15, 2024 13:15

quiet-node previously approved these changes Jul 15, 2024

View reviewed changes

quiet-node modified the milestones: 0.53.0, 0.52.0 Jul 15, 2024

Nana-EC requested changes Jul 15, 2024

View reviewed changes

fix: addressing comments

65bf766

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov dismissed quiet-node’s stale review via 65bf766 July 16, 2024 13:26

fix: set operator key

0ad8fa5

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

quiet-node modified the milestones: 0.53.0, 0.52.0 Jul 16, 2024

Ivo-Yankov requested a review from Nana-EC July 16, 2024 18:34

ebadiere previously approved these changes Jul 16, 2024

View reviewed changes

Nana-EC previously approved these changes Jul 16, 2024

View reviewed changes

packages/server/tests/acceptance/index.spec.ts Show resolved Hide resolved

packages/server/tests/clients/metricsClient.ts Show resolved Hide resolved

packages/server/tests/localAcceptance.env Outdated Show resolved Hide resolved

ebadiere reviewed Jul 16, 2024

View reviewed changes

packages/server/tests/localAcceptance.env Outdated Show resolved Hide resolved

test: check if switching operator in relay restart breaks sdkClient

210c592

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov dismissed stale reviews from Nana-EC and ebadiere via 210c592 July 17, 2024 11:33

Ivo-Yankov added 2 commits July 17, 2024 14:59

chore: remove .only

e16720d

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

fix: change operator for all tests

fe6dcc7

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov requested a review from georgi-l95 as a code owner July 17, 2024 15:27

Ivo-Yankov commented Jul 17, 2024

View reviewed changes

package.json Show resolved Hide resolved

Nana-EC previously approved these changes Jul 17, 2024

View reviewed changes

package.json Show resolved Hide resolved

packages/relay/src/lib/clients/sdkClient.ts Show resolved Hide resolved

packages/relay/src/lib/clients/sdkClient.ts Outdated Show resolved Hide resolved

Ivo-Yankov mentioned this pull request Jul 17, 2024

Add additional tests for FileAppend in eth_sendRawTransaction #2711

Open

chore: reverted an unwanted change

4b670dc

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Ivo-Yankov dismissed Nana-EC’s stale review via 4b670dc July 17, 2024 16:51

Nana-EC approved these changes Jul 17, 2024

View reviewed changes

quiet-node approved these changes Jul 17, 2024

View reviewed changes

quiet-node merged commit 9ead77c into main Jul 18, 2024
33 checks passed

quiet-node deleted the 2693-use-executeall-instead-of-execute-in-filecreateappend-transactions branch July 18, 2024 00:12

quiet-node modified the milestones: 0.52.0, 0.51.0 Jul 18, 2024

quiet-node mentioned this pull request Jul 18, 2024

Cherry pick PR #2698 #2715

Merged

2 tasks

quiet-node mentioned this pull request Jul 19, 2024

chore: cherry picked PR#2698 #2730

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE #2698

fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE #2698

Ivo-Yankov commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024 •

edited

Loading

quiet-node left a comment

Nana-EC left a comment

ebadiere left a comment

Nana-EC left a comment

Nana-EC left a comment

sonarcloud bot commented Jul 17, 2024

quiet-node left a comment

fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE #2698

fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE #2698

Conversation

Ivo-Yankov commented Jul 12, 2024 • edited Loading

github-actions bot commented Jul 12, 2024 • edited Loading

Tests

github-actions bot commented Jul 12, 2024 • edited Loading

Acceptance Tests

quiet-node left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

ebadiere left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 17, 2024

Quality Gate passed

quiet-node left a comment

Choose a reason for hiding this comment

Ivo-Yankov commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024 •

edited

Loading