-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE #2698
fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE #2698
Conversation
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ideas.
Some questions and clarifications
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, unblocking
Minor suggestions
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking but see minor items before merge
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: fix typo Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: code smell Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set lower hbar limit for acceptance tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: addressing comments Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set operator key Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: check if switching operator in relay restart breaks sdkClient Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: remove .only Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: change operator for all tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: reverted an unwanted change Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend * chore: code cleanup * chore: fix typo * nit: code smell * fix: set lower hbar limit for acceptance tests * fix: addressing comments * fix: set operator key * test: check if switching operator in relay restart breaks sdkClient * chore: remove .only * fix: change operator for all tests * chore: reverted an unwanted change --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: Ivo Yankov <ivo@devlabs.bg>
…CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: fix typo Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: code smell Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set lower hbar limit for acceptance tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: addressing comments Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set operator key Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: check if switching operator in relay restart breaks sdkClient Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: remove .only Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: change operator for all tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: reverted an unwanted change Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
…CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: fix typo Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: code smell Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set lower hbar limit for acceptance tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: addressing comments Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set operator key Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: check if switching operator in relay restart breaks sdkClient Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: remove .only Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: change operator for all tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: reverted an unwanted change Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
fix: Hbar usage tracking when transaction is larger than FILE_APPEND_CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend * chore: code cleanup * chore: fix typo * nit: code smell * fix: set lower hbar limit for acceptance tests * fix: addressing comments * fix: set operator key * test: check if switching operator in relay restart breaks sdkClient * chore: remove .only * fix: change operator for all tests * chore: reverted an unwanted change --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: Ivo Yankov <ivo@devlabs.bg>
…CHUNK_SIZE (#2698) * fix: use executeAll for fileAppend Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: fix typo Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: code smell Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set lower hbar limit for acceptance tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: addressing comments Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: set operator key Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: check if switching operator in relay restart breaks sdkClient Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: remove .only Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: change operator for all tests Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: reverted an unwanted change Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: ebadiere <ebadiere@gmail.com>
Description:
.execute()
with.executeAll()
forfileAppendTransaciton
. This way all transactions are returned in the result. Thetransaction_fee
is summed and subtracted from the remaining Hbar limit in the limiter class.sdkClient.ts
.HbarLimiter
.Related issue(s):
Fixes #2693
Notes for reviewer:
Checklist