test: add additional hbar limiter tests #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
…nce-tests Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> # Conflicts: # package.json # packages/relay/src/lib/clients/sdkClient.ts # packages/server/tests/acceptance/rateLimiter.spec.ts
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
…cal` Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
…the remaining hbar limiter balanace Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
|
konstantinabl
approved these changes
Jul 25, 2024
ebadiere
pushed a commit
that referenced
this pull request
Aug 1, 2024
* test: add additional hbar limiter tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> * chore: remove duplicate variable Signed-off-by: georgi-l95 <glazarov95@gmail.com> * chore: update tests after merge from main Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: move hbar limiter tests to separate job Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: small fix Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: small fix Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: do not restart relay and create accounts if `!global.relayIsLocal` Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: fix tests Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: fix tests Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: restore rateLimiter tests to be the same as before Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: improved assertions to compare the cost of the transaction and the remaining hbar limiter balanace Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: adjust expected costs Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: add `needs: hbarlimiter` to `publish_results` Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: change delta to 0.1% tolerance Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: extract common logic for checking remaining hbar limit Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> --------- Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> Co-authored-by: Victor Yanev <victor.yanev@limechain.tech> Signed-off-by: ebadiere <ebadiere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds aditional positive and negative scenarios for the HBar limiter acceptance test.
I've also set the limit for the suite to
300000000tinybars, this is just enough so that one contract deploy with fileCreate can pass and next one with fileCreate and fileAppend will fail.Related issue(s):
Fixes #2696
Fixes #2703
Notes for reviewer:
Checklist